QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: permission sqlalchemy events (#21454)

Browse Source
This commit is contained in:
Daniel Vaz Gaspar
2022-09-13 21:56:59 +01:00
committed by GitHub
parent 3098e657e5
commit 64d216adb3
2 changed files with 58 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/integration_tests/security_tests.py
View File

@@ -188,20 +188,13 @@ class TestRolePermission(SupersetTestCase):
self.assertIsNotNone(pvm_schema)
# assert on permission hooks
view_menu_dataset = security_manager.find_view_menu(
f"[tmp_db1].[tmp_perm_table](id:{table.id})"
)
view_menu_schema = security_manager.find_view_menu(f"[tmp_db1].[tmp_schema]")
security_manager.on_view_menu_after_insert.assert_has_calls(
[
call(ANY, ANY, view_menu_dataset),
call(ANY, ANY, view_menu_schema),
]
)
call_args = security_manager.on_permission_view_after_insert.call_args
assert call_args.args[2].id == pvm_schema.id
security_manager.on_permission_view_after_insert.assert_has_calls(
[
call(ANY, ANY, pvm_dataset),
call(ANY, ANY, pvm_schema),
call(ANY, ANY, ANY),
call(ANY, ANY, ANY),
]
)
@@ -289,9 +282,11 @@ class TestRolePermission(SupersetTestCase):
# Assert the hook is called
security_manager.on_permission_view_after_insert.assert_has_calls(
[
call(ANY, ANY, tmp_db1_pvm),
call(ANY, ANY, ANY),
]
)
call_args = security_manager.on_permission_view_after_insert.call_args
assert call_args.args[2].id == tmp_db1_pvm.id
session.delete(tmp_db1)
session.commit()