QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 23:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

[fix] make datasource names non-nullable (#8332)

Browse Source
This commit is contained in:
serenajiang
2019-10-04 09:13:26 -07:00
committed by Erik Ritter
parent b6b6a753e2
commit 65a05ca47e
9 changed files with 77 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/core_tests.py
View File

@@ -684,7 +684,9 @@ class CoreTests(SupersetTestCase):
def test_comments_in_sqlatable_query(self):
clean_query = "SELECT '/* val 1 */' as c1, '-- val 2' as c2 FROM tbl"
commented_query = "/* comment 1 */" + clean_query + "-- comment 2"
table = SqlaTable(sql=commented_query)
table = SqlaTable(
table_name="test_comments_in_sqlatable_query_table", sql=commented_query
)
rendered_query = str(table.get_from_clause())
self.assertEqual(clean_query, rendered_query)