QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-10 10:25:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove unused StringConstructor from return type

Browse Source 
Address review feedback from @michael-s-molina: Since the function
no longer returns String, remove StringConstructor from the return
type and update the misleading test description.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Evan Rusackas
2026-02-05 17:17:31 -08:00
parent 73eb0c11d4
commit 65cfebd889
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
superset-frontend/plugins/plugin-chart-echarts/test/utils/formatters.test.ts
View File

@@ -74,9 +74,7 @@ describe('getXAxisFormatter', () => {
expect(formatter).toEqual(expectedFormatter);
});
it('should return String constructor as fallback', () => {
// This test verifies that the String constructor is returned
// Note: the current logic may not reach this case, but keeping for completeness
it('should return undefined for falsy values', () => {
const formatter = getXAxisFormatter(null as any);
expect(formatter).toBeUndefined();
});