QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 19:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: apply capitalization guidelines - iteration 1 (#12447)

Browse Source 
Apply capitalization guidelines defined in #12343 

Use sentence casing for most places.
This commit is contained in:
Michael S. Molina
2021-01-12 15:47:55 -03:00
committed by GitHub
parent ed53b0090e
commit 6731cd0be6
11 changed files with 33 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterControl.tsx
View File

@@ -60,7 +60,7 @@ const guessFrame = (timeRange: string): FrameType => {
return 'Calendar';
}
if (timeRange === 'No filter') {
return 'No Filter';
return 'No filter';
}
if (customTimeRangeDecode(timeRange).matchedFlag) {
return 'Custom';
@@ -251,7 +251,7 @@ export default function DateFilterControl(props: DateFilterLabelProps) {
};
function onFrame(option: SelectOptionType) {
if (option.value === 'No Filter') {
if (option.value === 'No filter') {
setTimeRangeValue('No filter');
}
setFrame(option.value as FrameType);
@@ -266,7 +266,7 @@ export default function DateFilterControl(props: DateFilterLabelProps) {
onChange={onFrame}
className="frame-dropdown"
/>
{frame !== 'No Filter' && <Divider />}
{frame !== 'No filter' && <Divider />}
{frame === 'Common' && (
<CommonFrame value={timeRangeValue} onChange={setTimeRangeValue} />
)}
@@ -279,10 +279,10 @@ export default function DateFilterControl(props: DateFilterLabelProps) {
{frame === 'Custom' && (
<CustomFrame value={timeRangeValue} onChange={setTimeRangeValue} />
)}
{frame === 'No Filter' && <div data-test="no-filter" />}
{frame === 'No filter' && <div data-test="no-filter" />}
<Divider />
<div>
<div className="section-title">{t('Actual Time Range')}</div>
<div className="section-title">{t('Actual time range')}</div>
{validTimeRange && <div>{evalResponse}</div>}
{!validTimeRange && (
<IconWrapper className="warning">
@@ -321,7 +321,7 @@ export default function DateFilterControl(props: DateFilterLabelProps) {
const title = (
<IconWrapper>
<Icon name="edit-alt" />
<span className="text">{t('Edit Time Range')}</span>
<span className="text">{t('Edit time range')}</span>
</IconWrapper>
);

2
superset-frontend/src/explore/components/controls/DateFilterControl/constants.ts
View File

@@ -32,7 +32,7 @@ export const FRAME_OPTIONS: SelectOptionType[] = [
{ value: 'Calendar', label: t('Previous') },
{ value: 'Custom', label: t('Custom') },
{ value: 'Advanced', label: t('Advanced') },
{ value: 'No Filter', label: t('No Filter') },
{ value: 'No filter', label: t('No filter') },
];
export const COMMON_RANGE_OPTIONS: SelectOptionType[] = [

2
superset-frontend/src/explore/components/controls/DateFilterControl/types.ts
View File

@@ -26,7 +26,7 @@ export type FrameType =
| 'Calendar'
| 'Custom'
| 'Advanced'
| 'No Filter';
| 'No filter';
export type DateTimeGrainType =
| 'second'