QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 08:34:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(plugin-chart-echarts): use scale for truncating x-axis (#26269)

Browse Source
This commit is contained in:
Ville Brofeldt
2023-12-14 10:13:39 -08:00
committed by GitHub
parent 429e2a33c3
commit 67468c46c0
7 changed files with 172 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

105
superset-frontend/plugins/plugin-chart-echarts/test/utils/series.test.ts
View File

@@ -41,7 +41,11 @@ import {
sortAndFilterSeries,
sortRows,
} from '../../src/utils/series';
import { LegendOrientation, LegendType } from '../../src/types';
import {
EchartsTimeseriesSeriesType,
LegendOrientation,
LegendType,
} from '../../src/types';
import { defaultLegendPadding } from '../../src/defaults';
import { NULL_STRING } from '../../src/constants';
@@ -885,28 +889,109 @@ test('getAxisType', () => {
});
test('getMinAndMaxFromBounds returns empty object when not truncating', () => {
expect(getMinAndMaxFromBounds(AxisType.value, false, 10, 100)).toEqual({});
expect(
getMinAndMaxFromBounds(
AxisType.value,
false,
10,
100,
EchartsTimeseriesSeriesType.Bar,
),
).toEqual({});
});
test('getMinAndMaxFromBounds returns automatic bounds when truncating', () => {
test('getMinAndMaxFromBounds returns empty object for categorical axis', () => {
expect(
getMinAndMaxFromBounds(AxisType.value, true, undefined, undefined),
getMinAndMaxFromBounds(
AxisType.category,
false,
10,
100,
EchartsTimeseriesSeriesType.Bar,
),
).toEqual({});
});
test('getMinAndMaxFromBounds returns empty object for time axis', () => {
expect(
getMinAndMaxFromBounds(
AxisType.time,
false,
10,
100,
EchartsTimeseriesSeriesType.Bar,
),
).toEqual({});
});
test('getMinAndMaxFromBounds returns dataMin/dataMax for non-bar charts', () => {
expect(
getMinAndMaxFromBounds(
AxisType.value,
true,
undefined,
undefined,
EchartsTimeseriesSeriesType.Line,
),
).toEqual({
min: 'dataMin',
max: 'dataMax',
});
});
test('getMinAndMaxFromBounds returns automatic upper bound when truncating', () => {
expect(getMinAndMaxFromBounds(AxisType.value, true, 10, undefined)).toEqual({
test('getMinAndMaxFromBounds returns bound without scale for non-bar charts', () => {
expect(
getMinAndMaxFromBounds(
AxisType.value,
true,
10,
undefined,
EchartsTimeseriesSeriesType.Line,
),
).toEqual({
min: 10,
max: 'dataMax',
});
});
test('getMinAndMaxFromBounds returns automatic lower bound when truncating', () => {
expect(getMinAndMaxFromBounds(AxisType.value, true, undefined, 100)).toEqual({
min: 'dataMin',
max: 100,
test('getMinAndMaxFromBounds returns scale when truncating without bounds', () => {
expect(
getMinAndMaxFromBounds(
AxisType.value,
true,
undefined,
undefined,
EchartsTimeseriesSeriesType.Bar,
),
).toEqual({ scale: true });
});
test('getMinAndMaxFromBounds returns automatic upper bound when truncating', () => {
expect(
getMinAndMaxFromBounds(
AxisType.value,
true,
10,
undefined,
EchartsTimeseriesSeriesType.Bar,
),
).toEqual({
min: 10,
scale: true,
});
});
test('getMinAndMaxFromBounds returns automatic lower bound when truncating', () => {
expect(
getMinAndMaxFromBounds(
AxisType.value,
true,
undefined,
100,
EchartsTimeseriesSeriesType.Bar,
),
).toEqual({
max: 100,
scale: true,
});
});