QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Explore] Streamlined metric definitions for SQLA and Druid (#4663)

Browse Source 
* adding streamlined metric editing

* addressing lint issues on new metrics control

* enabling druid
This commit is contained in:
Gabe Lyons
2018-03-28 17:41:29 -07:00
committed by Maxime Beauchemin
parent 7e1b6b7363
commit 68dec24542
36 changed files with 1517 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
superset/assets/spec/javascripts/explore/components/MetricDefinitionValue_spec.jsx Normal file
View File

@@ -0,0 +1,30 @@
/* eslint-disable no-unused-expressions */
import React from 'react';
import { expect } from 'chai';
import { describe, it } from 'mocha';
import { shallow } from 'enzyme';
import MetricDefinitionValue from '../../../../javascripts/explore/components/MetricDefinitionValue';
import MetricOption from '../../../../javascripts/components/MetricOption';
import AdhocMetricOption from '../../../../javascripts/explore/components/AdhocMetricOption';
import AdhocMetric from '../../../../javascripts/explore/AdhocMetric';
import { AGGREGATES } from '../../../../javascripts/explore/constants';
const sumValueAdhocMetric = new AdhocMetric({
column: { type: 'DOUBLE', column_name: 'value' },
aggregate: AGGREGATES.SUM,
});
describe('MetricDefinitionValue', () => {
it('renders a MetricOption given a saved metric', () => {
const wrapper = shallow(<MetricDefinitionValue option={{ metric_name: 'a_saved_metric' }} />);
expect(wrapper.find(MetricOption)).to.have.lengthOf(1);
});
it('renders an AdhocMetricOption given an adhoc metric', () => {
const wrapper = shallow((
<MetricDefinitionValue onMetricEdit={() => {}} option={sumValueAdhocMetric} />
));
expect(wrapper.find(AdhocMetricOption)).to.have.lengthOf(1);
});
});