QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Caching] Ensure cache is always created (#9020)

Browse Source 
* [Caching] Ensure cache is always created

* Update cache_manager.py

* Refactoring cache typing
This commit is contained in:
Erik Ritter
2020-01-25 14:49:05 -08:00
committed by Daniel Vaz Gaspar
parent c552c852cd
commit 68e85ab1b6
4 changed files with 39 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
superset/utils/cache_manager.py
View File

@@ -14,11 +14,11 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
from typing import Optional
from flask import Flask
from flask_caching import Cache
from superset.typing import CacheConfig
class CacheManager:
def __init__(self) -> None:
@@ -27,30 +27,26 @@ class CacheManager:
self._tables_cache = None
self._cache = None
def init_app(self, app):
self._cache = self._setup_cache(app, app.config.get("CACHE_CONFIG"))
def init_app(self, app: Flask) -> None:
self._cache = self._setup_cache(app, app.config["CACHE_CONFIG"])
self._tables_cache = self._setup_cache(
app, app.config.get("TABLE_NAMES_CACHE_CONFIG")
app, app.config["TABLE_NAMES_CACHE_CONFIG"]
)
@staticmethod
def _setup_cache(app: Flask, cache_config) -> Optional[Cache]:
def _setup_cache(app: Flask, cache_config: CacheConfig) -> Cache:
"""Setup the flask-cache on a flask app"""
if cache_config:
if isinstance(cache_config, dict):
if cache_config.get("CACHE_TYPE") != "null":
return Cache(app, config=cache_config)
else:
# Accepts a custom cache initialization function,
# returning an object compatible with Flask-Caching API
return cache_config(app)
if isinstance(cache_config, dict):
return Cache(app, config=cache_config)
return None
# Accepts a custom cache initialization function, returning an object compatible
# with Flask-Caching API.
return cache_config(app)
@property
def tables_cache(self):
def tables_cache(self) -> Cache:
return self._tables_cache
@property
def cache(self):
def cache(self) -> Cache:
return self._cache