QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-09 03:16:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: feature flags typing (#15254)

Browse Source 
* fix: feature flags typing

* fix tests

* add note in UPDATING.md

* fix frontend

* also move SCHEDULED_QUERIES to top level

* fix test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
This commit is contained in:
Daniel Vaz Gaspar
2021-11-19 15:56:16 +00:00
committed by GitHub
parent 02a9b84b14
commit 69f9ee8f5e
10 changed files with 45 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tests/integration_tests/sql_validator_tests.py
View File

@@ -34,13 +34,11 @@ from superset.utils.core import get_example_database
from .base_tests import SupersetTestCase
PRESTO_TEST_FEATURE_FLAGS = {
"SQL_VALIDATORS_BY_ENGINE": {
"presto": "PrestoDBSQLValidator",
"sqlite": "PrestoDBSQLValidator",
"postgresql": "PrestoDBSQLValidator",
"mysql": "PrestoDBSQLValidator",
}
PRESTO_SQL_VALIDATORS_BY_ENGINE = {
"presto": "PrestoDBSQLValidator",
"sqlite": "PrestoDBSQLValidator",
"postgresql": "PrestoDBSQLValidator",
"mysql": "PrestoDBSQLValidator",
}
@@ -65,8 +63,8 @@ class TestSqlValidatorEndpoint(SupersetTestCase):
@patch("superset.views.core.get_validator_by_name")
@patch.dict(
"superset.extensions.feature_flag_manager._feature_flags",
PRESTO_TEST_FEATURE_FLAGS,
"superset.config.SQL_VALIDATORS_BY_ENGINE",
PRESTO_SQL_VALIDATORS_BY_ENGINE,
clear=True,
)
def test_validate_sql_endpoint_mocked(self, get_validator_by_name):
@@ -98,8 +96,8 @@ class TestSqlValidatorEndpoint(SupersetTestCase):
@patch("superset.views.core.get_validator_by_name")
@patch.dict(
"superset.extensions.feature_flag_manager._feature_flags",
PRESTO_TEST_FEATURE_FLAGS,
"superset.config.SQL_VALIDATORS_BY_ENGINE",
PRESTO_SQL_VALIDATORS_BY_ENGINE,
clear=True,
)
def test_validate_sql_endpoint_failure(self, get_validator_by_name):