diff --git a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.test.tsx b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.test.tsx index 3a1325875cf..93d00a70592 100644 --- a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.test.tsx +++ b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.test.tsx @@ -29,7 +29,7 @@ const defaultProps: LabelProps = { test('renders with default props', () => { render(, { useDnd: true }); - expect(screen.getByText('Drop columns')).toBeInTheDocument(); + expect(screen.getByText('Drop columns here')).toBeInTheDocument(); }); test('renders with value', () => { diff --git a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx index e8f64db146c..46b3889fdd6 100644 --- a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx +++ b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx @@ -143,7 +143,8 @@ export const DndColumnSelect = (props: LabelProps) => { accept={DndItemType.Column} displayGhostButton={multi || optionSelector.values.length === 0} ghostButtonText={ - ghostButtonText || tn('Drop column', 'Drop columns', multi ? 2 : 1) + ghostButtonText || + tn('Drop column here', 'Drop columns here', multi ? 2 : 1) } {...props} /> diff --git a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.test.tsx b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.test.tsx index bf7d135b788..bddb80a9aa2 100644 --- a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.test.tsx +++ b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.test.tsx @@ -38,7 +38,7 @@ const defaultProps = { test('renders with default props', () => { render(, { useDnd: true }); - expect(screen.getByText('Drop columns or metrics')).toBeInTheDocument(); + expect(screen.getByText('Drop columns or metrics here')).toBeInTheDocument(); }); test('renders with value', () => { @@ -56,7 +56,7 @@ test('renders options with saved metric', () => { render(, { useDnd: true, }); - expect(screen.getByText('Drop columns or metrics')).toBeInTheDocument(); + expect(screen.getByText('Drop columns or metrics here')).toBeInTheDocument(); }); test('renders options with column', () => { @@ -76,7 +76,7 @@ test('renders options with column', () => { useDnd: true, }, ); - expect(screen.getByText('Drop columns or metrics')).toBeInTheDocument(); + expect(screen.getByText('Drop columns or metrics here')).toBeInTheDocument(); }); test('renders options with adhoc metric', () => { @@ -87,5 +87,5 @@ test('renders options with adhoc metric', () => { render(, { useDnd: true, }); - expect(screen.getByText('Drop columns or metrics')).toBeInTheDocument(); + expect(screen.getByText('Drop columns or metrics here')).toBeInTheDocument(); }); diff --git a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.tsx b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.tsx index dc7e892e3fe..66849b2d1f5 100644 --- a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.tsx +++ b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.tsx @@ -374,7 +374,7 @@ export const DndFilterSelect = (props: DndFilterSelectProps) => { canDrop={canDrop} valuesRenderer={valuesRenderer} accept={DND_ACCEPTED_TYPES} - ghostButtonText={t('Drop columns or metrics')} + ghostButtonText={t('Drop columns or metrics here')} {...props} /> { render(, { useDnd: true }); - expect(screen.getByText('Drop column or metric')).toBeInTheDocument(); + expect(screen.getByText('Drop column or metric here')).toBeInTheDocument(); }); test('renders with default props and multi = true', () => { render(, { useDnd: true }); - expect(screen.getByText('Drop columns or metrics')).toBeInTheDocument(); + expect(screen.getByText('Drop columns or metrics here')).toBeInTheDocument(); }); diff --git a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx index 77dbfa3285d..ed32e1b9070 100644 --- a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx +++ b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx @@ -334,8 +334,8 @@ export const DndMetricSelect = (props: any) => { valuesRenderer={valuesRenderer} accept={DND_ACCEPTED_TYPES} ghostButtonText={tn( - 'Drop column or metric', - 'Drop columns or metrics', + 'Drop column or metric here', + 'Drop columns or metrics here', multi ? 2 : 1, )} displayGhostButton={multi || value.length === 0} diff --git a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndSelectLabel.test.tsx b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndSelectLabel.test.tsx index d6090e2a269..d9689d7e8d2 100644 --- a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndSelectLabel.test.tsx +++ b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndSelectLabel.test.tsx @@ -33,7 +33,7 @@ const defaultProps = { test('renders with default props', async () => { render(, { useDnd: true }); - expect(await screen.findByText('Drop columns')).toBeInTheDocument(); + expect(await screen.findByText('Drop columns here')).toBeInTheDocument(); }); test('renders ghost button when empty', async () => { diff --git a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndSelectLabel.tsx b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndSelectLabel.tsx index daaeb918528..7ffdb175e2a 100644 --- a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndSelectLabel.tsx +++ b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndSelectLabel.tsx @@ -55,7 +55,7 @@ export default function DndSelectLabel({ return ( - {t(props.ghostButtonText || 'Drop columns')} + {t(props.ghostButtonText || 'Drop columns here')} ); }