mirror of
https://github.com/apache/superset.git
synced 2026-04-25 11:04:48 +00:00
feat(timeseries-chart): add percentage threshold input control (#17758)
* feat(timeseries-chart): add percentage threshold control for stack series labels * feat: move threshold vlues to an array * add tests for showValue, onlyTotal, and percentThreshold * feat: add another test * revert ChartProps typesetting, fix misnamed variable on form data type, and other minor changes * fix percentage threshold push equation * fix percentage threshold push equation in tests * change default on control to match form * attempt fix form defaults import Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
This commit is contained in:
@@ -24,6 +24,7 @@ import {
|
||||
sharedControls,
|
||||
} from '@superset-ui/chart-controls';
|
||||
import { DEFAULT_LEGEND_FORM_DATA } from './types';
|
||||
import { DEFAULT_FORM_DATA } from './Timeseries/types';
|
||||
|
||||
const { legendMargin, legendOrientation, legendType, showLegend } =
|
||||
DEFAULT_LEGEND_FORM_DATA;
|
||||
@@ -136,10 +137,29 @@ const onlyTotalControl = {
|
||||
},
|
||||
};
|
||||
|
||||
const percentageThresholdControl = {
|
||||
name: 'percentage_threshold',
|
||||
config: {
|
||||
type: 'TextControl',
|
||||
label: t('Percentage threshold'),
|
||||
renderTrigger: true,
|
||||
isFloat: true,
|
||||
default: DEFAULT_FORM_DATA.percentageThreshold,
|
||||
description: t(
|
||||
'Minimum threshold in percentage points for showing labels.',
|
||||
),
|
||||
visibility: ({ controls }: ControlPanelsContainerProps) =>
|
||||
Boolean(controls?.show_value?.value) &&
|
||||
Boolean(controls?.stack?.value) &&
|
||||
Boolean(!controls?.only_total?.value),
|
||||
},
|
||||
};
|
||||
|
||||
export const showValueSection = [
|
||||
[showValueControl],
|
||||
[stackControl],
|
||||
[onlyTotalControl],
|
||||
[percentageThresholdControl],
|
||||
];
|
||||
|
||||
const richTooltipControl = {
|
||||
|
||||
Reference in New Issue
Block a user