From 6ce3885f2ee37573057fbef11b2794e149756a3a Mon Sep 17 00:00:00 2001
From: "Michael S. Molina" <70410625+michael-s-molina@users.noreply.github.com>
Date: Wed, 29 Apr 2026 15:04:34 -0300
Subject: [PATCH] chore(build): remove thread-loader from webpack build
 (#39763)

---
 scripts/oxlint.sh                   | 12 +++++++++++-
 superset-frontend/package-lock.json | 24 ------------------------
 superset-frontend/package.json      |  1 -
 superset-frontend/webpack.config.js |  5 +----
 4 files changed, 12 insertions(+), 30 deletions(-)

diff --git a/scripts/oxlint.sh b/scripts/oxlint.sh
index 5eb984f0b3a..95f48afabb6 100755
--- a/scripts/oxlint.sh
+++ b/scripts/oxlint.sh
@@ -45,7 +45,17 @@ if [ ${#js_ts_files[@]} -gt 0 ]; then
   # Skip custom OXC build in pre-commit for speed
   export SKIP_CUSTOM_OXC=true
   # Use quiet mode in pre-commit to reduce noise (only show errors)
-  npx oxlint --config oxlint.json --fix --quiet "${js_ts_files[@]}"
+  # Capture output so we can treat "No files found" (all files ignored by
+  # ignorePatterns) as success rather than a false-positive failure.
+  output=$(npx oxlint --config oxlint.json --fix --quiet "${js_ts_files[@]}" 2>&1) || {
+    if echo "$output" | grep -q "No files found"; then
+      echo "No files to lint after applying ignore patterns"
+      exit 0
+    fi
+    echo "$output" >&2
+    exit 1
+  }
+  [ -n "$output" ] && echo "$output"
 else
   echo "No JavaScript/TypeScript files to lint"
 fi
diff --git a/superset-frontend/package-lock.json b/superset-frontend/package-lock.json
index a7f12438a15..f55698397a6 100644
--- a/superset-frontend/package-lock.json
+++ b/superset-frontend/package-lock.json
@@ -280,7 +280,6 @@
         "style-loader": "^4.0.0",
         "swc-loader": "^0.2.7",
         "terser-webpack-plugin": "^5.5.0",
-        "thread-loader": "^4.0.4",
         "ts-jest": "^29.4.9",
         "tscw-config": "^1.1.2",
         "tsx": "^4.21.0",
@@ -46704,29 +46703,6 @@
         "tslib": "^2"
       }
     },
-    "node_modules/thread-loader": {
-      "version": "4.0.4",
-      "resolved": "https://registry.npmjs.org/thread-loader/-/thread-loader-4.0.4.tgz",
-      "integrity": "sha512-tXagu6Hivd03wB2tiS1bqvw345sc7mKei32EgpYpq31ZLes9FN0mEK2nKzXLRFgwt3PsBB0E/MZDp159rDoqwg==",
-      "dev": true,
-      "license": "MIT",
-      "dependencies": {
-        "json-parse-better-errors": "^1.0.2",
-        "loader-runner": "^4.1.0",
-        "neo-async": "^2.6.2",
-        "schema-utils": "^4.2.0"
-      },
-      "engines": {
-        "node": ">= 16.10.0"
-      },
-      "funding": {
-        "type": "opencollective",
-        "url": "https://opencollective.com/webpack"
-      },
-      "peerDependencies": {
-        "webpack": "^5.0.0"
-      }
-    },
     "node_modules/throttle-debounce": {
       "version": "5.0.2",
       "resolved": "https://registry.npmjs.org/throttle-debounce/-/throttle-debounce-5.0.2.tgz",
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
index 5b297f5e5db..296eb140036 100644
--- a/superset-frontend/package.json
+++ b/superset-frontend/package.json
@@ -361,7 +361,6 @@
     "style-loader": "^4.0.0",
     "swc-loader": "^0.2.7",
     "terser-webpack-plugin": "^5.5.0",
-    "thread-loader": "^4.0.4",
     "ts-jest": "^29.4.9",
     "tscw-config": "^1.1.2",
     "tsx": "^4.21.0",
diff --git a/superset-frontend/webpack.config.js b/superset-frontend/webpack.config.js
index d24ccfb4a25..981d7f1f819 100644
--- a/superset-frontend/webpack.config.js
+++ b/superset-frontend/webpack.config.js
@@ -505,10 +505,7 @@ const config = {
       {
         test: /\.tsx?$/,
         exclude: [/\.test.tsx?$/, /node_modules/],
-        // Skip thread-loader in dev mode - it breaks HMR by running in worker threads
-        use: isDevMode
-          ? [createSwcLoader('typescript', true)]
-          : ['thread-loader', createSwcLoader('typescript', true)],
+        use: [createSwcLoader('typescript', true)],
       },
       {
         test: /\.jsx?$/,