QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-22 09:35:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(sql lab): display the 'View Results' button consistently in the history tab on sync mode (#19362)

Browse Source 
* fix(sql lab): display the 'View Results' button in the history tab when running sync queries

* pr comment
This commit is contained in:
Diego Medina
2022-04-13 12:20:32 -04:00
committed by GitHub
parent c8304a2821
commit 6d5d03e592
3 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
superset-frontend/src/SqlLab/components/ResultSet/index.tsx
View File

@@ -247,9 +247,16 @@ export default class ResultSet extends React.PureComponent<
this.clearQueryResults(nextProps.query),
);
}
// Only fetch results if the result key change
// If we didn't have a result key before, then the results are loaded elsewhere
// so we can skip it, unless the query id changed, in that case we should
// refetch regardless.
if (
nextProps.query.resultsKey &&
nextProps.query.resultsKey !== this.props.query.resultsKey
(this.props.query.resultsKey &&
nextProps.query.resultsKey &&
nextProps.query.resultsKey !== this.props.query.resultsKey) ||
(nextProps.query.id !== this.props.query.id && nextProps.query.resultsKey)
) {
this.fetchResults(nextProps.query);
}