diff --git a/RESOURCES/STANDARD_ROLES.md b/RESOURCES/STANDARD_ROLES.md index 207474c9abe..48c80174453 100644 --- a/RESOURCES/STANDARD_ROLES.md +++ b/RESOURCES/STANDARD_ROLES.md @@ -94,9 +94,9 @@ under the License. | can available domains on Superset |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O| | can request access on Superset |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O| | can dashboard on Superset |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O| -| can post on TableSchemaView |:heavy_check_mark:|:heavy_check_mark:|O|O| -| can expanded on TableSchemaView |:heavy_check_mark:|:heavy_check_mark:|O|O| -| can delete on TableSchemaView |:heavy_check_mark:|:heavy_check_mark:|O|O| +| can post on TableSchemaView |:heavy_check_mark:|O|O|:heavy_check_mark:| +| can expanded on TableSchemaView |:heavy_check_mark:|O|O|:heavy_check_mark:| +| can delete on TableSchemaView |:heavy_check_mark:|O|O|:heavy_check_mark:| | can get on TabStateView |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:| | can post on TabStateView |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:| | can delete query on TabStateView |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:| diff --git a/superset/security/manager.py b/superset/security/manager.py index dd5ff147eac..339bbbe2ab3 100644 --- a/superset/security/manager.py +++ b/superset/security/manager.py @@ -307,7 +307,6 @@ class SupersetSecurityManager( # pylint: disable=too-many-public-methods "Manage", "Queries", "ReportSchedule", - "TableSchemaView", } ALPHA_ONLY_PMVS = { @@ -376,6 +375,9 @@ class SupersetSecurityManager( # pylint: disable=too-many-public-methods ("menu_access", "Query Search"), ("can_read", "SqlLabPermalinkRestApi"), ("can_write", "SqlLabPermalinkRestApi"), + ("can_post", "TableSchemaView"), + ("can_expanded", "TableSchemaView"), + ("can_delete", "TableSchemaView"), } SQLLAB_EXTRA_PERMISSION_VIEWS = { diff --git a/tests/integration_tests/security_tests.py b/tests/integration_tests/security_tests.py index dad8a3d47eb..88c0f5178dc 100644 --- a/tests/integration_tests/security_tests.py +++ b/tests/integration_tests/security_tests.py @@ -1495,6 +1495,9 @@ class TestRolePermission(SupersetTestCase): ("menu_access", "SQL Lab"), ("can_read", "SqlLabPermalinkRestApi"), ("can_write", "SqlLabPermalinkRestApi"), + ("can_post", "TableSchemaView"), + ("can_expanded", "TableSchemaView"), + ("can_delete", "TableSchemaView"), } self.assert_cannot_alpha(sql_lab_set)