QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 23:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: refine timestamp expr function (#21510)

Browse Source
This commit is contained in:
Yongjie Zhao
2022-09-20 18:51:01 +08:00
committed by GitHub
parent 42000823be
commit 737d4dcf0c
4 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
superset/db_engine_specs/base.py
View File

@@ -476,7 +476,6 @@ class BaseEngineSpec: # pylint: disable=too-many-public-methods
col: ColumnClause,
pdf: Optional[str],
time_grain: Optional[str],
type_: Optional[str] = None,
) -> TimestampExpression:
"""
Construct a TimestampExpression to be used in a SQLAlchemy query.
@@ -484,10 +483,10 @@ class BaseEngineSpec: # pylint: disable=too-many-public-methods
:param col: Target column for the TimestampExpression
:param pdf: date format (seconds or milliseconds)
:param time_grain: time grain, e.g. P1Y for 1 year
:param type_: the source column type
:return: TimestampExpression object
"""
if time_grain:
type_ = str(getattr(col, "type", ""))
time_expr = cls.get_time_grain_expressions().get(time_grain)
if not time_expr:
raise NotImplementedError(