QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 23:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(dashboard): Add ErrorBoudary for AdhocFilter components (#12352)

Browse Source 
* Add ErrorBoudary for AdhocFilter components

* Add tests

* typo fix
This commit is contained in:
Nikola Gigić
2021-01-08 19:58:26 +01:00
committed by GitHub
parent 78d3557757
commit 737e6b4aee
2 changed files with 44 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
superset-frontend/spec/javascripts/explore/components/AdhocFilterEditPopover_spec.jsx
View File

@@ -22,6 +22,7 @@ import sinon from 'sinon';
import { shallow } from 'enzyme';
import Button from 'src/components/Button';
import ErrorBoundary from 'src/components/ErrorBoundary';
import Tabs from 'src/common/components/Tabs';
import AdhocFilter, {
EXPRESSION_TYPES,
@@ -47,6 +48,14 @@ const sqlAdhocFilter = new AdhocFilter({
clause: CLAUSES.WHERE,
});
const faultyAdhocFilter = new AdhocFilter({
expressionType: null,
subject: null,
operator: '>',
comparator: '10',
clause: CLAUSES.WHERE,
});
const sumValueAdhocMetric = new AdhocMetric({
expressionType: EXPRESSION_TYPES.SIMPLE,
column: { type: 'VARCHAR(255)', column_name: 'source' },
@@ -97,6 +106,14 @@ describe('AdhocFilterEditPopover', () => {
expect(wrapper.find(AdhocFilterEditPopoverSqlTabContent)).toExist();
});
it('renders simple and sql tabs with ErrorBoundary instead of content', () => {
const { wrapper } = setup({ adhocFilter: faultyAdhocFilter });
expect(wrapper.find(Tabs)).toExist();
expect(wrapper.find(Tabs.TabPane)).toHaveLength(2);
expect(wrapper.find(Button)).toHaveLength(2);
expect(wrapper.find(ErrorBoundary)).toHaveLength(2);
});
it('overwrites the adhocFilter in state with onAdhocFilterChange', () => {
const { wrapper } = setup();
wrapper.instance().onAdhocFilterChange(sqlAdhocFilter);