QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-14 05:34:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

[explore] force control validation before runQuery (#2544)

Browse Source 
* [explore] force control validation before runQuery

* Addressing comments
This commit is contained in:
Maxime Beauchemin
2017-04-10 21:45:44 -07:00
committed by GitHub
parent 493ba18362
commit 75a358c616
7 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
superset/assets/javascripts/explorev2/components/ExploreViewContainer.jsx
View File

@@ -47,7 +47,7 @@ class ExploreViewContainer extends React.Component {
}
componentDidUpdate() {
if (this.props.triggerQuery) {
if (this.props.triggerQuery && !this.hasErrors()) {
this.runQuery();
}
}
@@ -95,6 +95,10 @@ class ExploreViewContainer extends React.Component {
toggleModal() {
this.setState({ showModal: !this.state.showModal });
}
hasErrors() {
const ctrls = this.props.controls;
return Object.keys(ctrls).some(k => ctrls[k].validationErrors.length > 0);
}
renderErrorMessage() {
// Returns an error message as a node if any errors are in the store
const errors = [];