diff --git a/superset-frontend/src/components/Chart/DrillBy/DrillByModal.test.tsx b/superset-frontend/src/components/Chart/DrillBy/DrillByModal.test.tsx index 79c41f30aa1..05b0194f5f8 100644 --- a/superset-frontend/src/components/Chart/DrillBy/DrillByModal.test.tsx +++ b/superset-frontend/src/components/Chart/DrillBy/DrillByModal.test.tsx @@ -593,6 +593,7 @@ describe('Table view with pagination', () => { expect.objectContaining({ resultFormat: 'csv', resultType: 'full', + formData: expect.objectContaining({ slice_id: 0 }), }), ); }); @@ -623,6 +624,7 @@ describe('Table view with pagination', () => { expect.objectContaining({ resultFormat: 'xlsx', resultType: 'full', + formData: expect.objectContaining({ slice_id: 0 }), }), ); }); diff --git a/superset-frontend/src/explore/components/DataTablesPane/types.ts b/superset-frontend/src/explore/components/DataTablesPane/types.ts index 6e6a2c4b061..6135bb6fe38 100644 --- a/superset-frontend/src/explore/components/DataTablesPane/types.ts +++ b/superset-frontend/src/explore/components/DataTablesPane/types.ts @@ -63,7 +63,13 @@ export interface SamplesPaneProps { canDownload: boolean; } -export interface TableControlsProps { +export interface DrillControlsProps { + onDownloadCSV?: () => void; + onDownloadXLSX?: () => void; + onReload?: () => void; +} + +export interface TableControlsProps extends DrillControlsProps { data: Record[]; // {datasource.id}__{datasource.type}, eg: 1__table datasourceId?: string; @@ -76,9 +82,6 @@ export interface TableControlsProps { rowLimit?: number; rowLimitOptions?: { value: number; label: string }[]; onRowLimitChange?: (limit: number) => void; - onDownloadCSV?: () => void; - onDownloadXLSX?: () => void; - onReload?: () => void; } export interface QueryResultInterface { @@ -88,7 +91,8 @@ export interface QueryResultInterface { data: Record[][]; } -export interface SingleQueryResultPaneProp extends QueryResultInterface { +export interface SingleQueryResultPaneProp + extends QueryResultInterface, DrillControlsProps { // {datasource.id}__{datasource.type}, eg: 1__table datasourceId?: string; isVisible: boolean; @@ -98,7 +102,4 @@ export interface SingleQueryResultPaneProp extends QueryResultInterface { rowLimit?: number; rowLimitOptions?: { value: number; label: string }[]; onRowLimitChange?: (limit: number) => void; - onDownloadCSV?: () => void; - onDownloadXLSX?: () => void; - onReload?: () => void; }