QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Fixing pinot query generation for date format conversion from python datetime format to java simple date format (#13163)

Browse Source 
* Fixing pinot query generation for date format conversion from python datetime format to java simple date format

* Address comments

* fix test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
This commit is contained in:
Xiang Fu
2021-02-19 22:26:34 -08:00
committed by GitHub
parent eea5fe3b60
commit 786c12d52d
2 changed files with 52 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
tests/db_engine_specs/pinot_tests.py
View File

@@ -30,7 +30,32 @@ class TestPinotDbEngineSpec(TestDbEngineSpec):
self.assertEqual(
result,
"DATETIMECONVERT(tstamp, '1:SECONDS:EPOCH', '1:SECONDS:EPOCH', '1:DAYS')",
) # noqa
)
def test_pinot_time_expression_simple_date_format_1d_grain(self):
col = column("tstamp")
expr = PinotEngineSpec.get_timestamp_expr(col, "%Y-%m-%d %H:%M:%S", "P1D")
result = str(expr.compile())
self.assertEqual(
result,
(
"DATETIMECONVERT(tstamp, "
+ "'1:SECONDS:SIMPLE_DATE_FORMAT:yyyy-MM-dd HH:mm:ss', "
+ "'1:SECONDS:SIMPLE_DATE_FORMAT:yyyy-MM-dd HH:mm:ss', '1:DAYS')"
),
)
def test_pinot_time_expression_simple_date_format_1w_grain(self):
col = column("tstamp")
expr = PinotEngineSpec.get_timestamp_expr(col, "%Y-%m-%d %H:%M:%S", "P1W")
result = str(expr.compile())
self.assertEqual(
result,
(
"ToDateTime(DATETRUNC('week', FromDateTime(tstamp, "
+ "'yyyy-MM-dd HH:mm:ss'), 'MILLISECONDS'), 'yyyy-MM-dd HH:mm:ss')"
),
)
def test_pinot_time_expression_sec_one_1m_grain(self):
col = column("tstamp")
@@ -38,4 +63,13 @@ class TestPinotDbEngineSpec(TestDbEngineSpec):
result = str(expr.compile())
self.assertEqual(
result, "DATETRUNC('month', tstamp, 'SECONDS')",
) # noqa
)
def test_invalid_get_time_expression_arguments(self):
with self.assertRaises(NotImplementedError):
PinotEngineSpec.get_timestamp_expr(column("tstamp"), None, "P1M")
with self.assertRaises(NotImplementedError):
PinotEngineSpec.get_timestamp_expr(
column("tstamp"), "epoch_s", "invalid_grain"
)