fix: Ensure consistent rollback logic (#20811)

2026-04-25 02:55:07 +00:00 · 2022-07-25 08:18:53 -07:00
parent 0945d4a2f4
commit 7a1aa79c52
6 changed files with 7 additions and 14 deletions
--- a/superset/annotation_layers/annotations/dao.py
+++ b/superset/annotation_layers/annotations/dao.py
@@ -40,8 +40,7 @@ class AnnotationDAO(BaseDAO):
            if commit:
                db.session.commit()
        except SQLAlchemyError as ex:
-            if commit:
-                db.session.rollback()
+            db.session.rollback()
            raise DAODeleteFailedError() from ex

    @staticmethod