QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-22 09:35:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

[sql_lab]Disabled run query button if sql query editor is empty (#4728)

Browse Source 
* Disabled run query button if sql query editor is empty

* Removing unnecessary white space

* Fix failing test for sql props

* Adding sql variable into propTypes and defaultProps
This commit is contained in:
Prashant
2018-04-04 03:28:23 +05:30
committed by Maxime Beauchemin
parent f6fe11f76e
commit 7a497e2f6b
3 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
superset/assets/javascripts/SqlLab/components/RunQueryActionButton.jsx
View File

@@ -10,9 +10,11 @@ const propTypes = {
runQuery: PropTypes.func.isRequired,
selectedText: PropTypes.string,
stopQuery: PropTypes.func.isRequired,
sql: PropTypes.string.isRequired,
};
const defaultProps = {
allowAsync: false,
sql: '',
};
export default function RunQueryActionButton(props) {
@@ -32,6 +34,7 @@ export default function RunQueryActionButton(props) {
onClick={() => props.runQuery(false)}
key="run-btn"
tooltip={t('Run query synchronously')}
disabled={!props.sql.trim()}
>
<i className="fa fa-refresh" /> {runBtnText}
</Button>
@@ -43,6 +46,7 @@ export default function RunQueryActionButton(props) {
onClick={() => props.runQuery(true)}
key="run-async-btn"
tooltip={t('Run query asynchronously')}
disabled={!props.sql.trim()}
>
<i className="fa fa-table" /> {runBtnText}
</Button>