QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Revert "Replace reactable with DataTable from superset-ui in QueryTable (#10981)" (#11125)

Browse Source 
This reverts commit e93d92e8ac.
This commit is contained in:
ʈᵃᵢ
2020-10-01 10:06:22 -07:00
committed by GitHub
parent 50d80405a9
commit 7a72082d31
3 changed files with 19 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
superset-frontend/spec/javascripts/sqllab/QueryTable_spec.jsx
View File

@@ -18,33 +18,27 @@
*/
import React from 'react';
import { shallow } from 'enzyme';
import DataTable from '@superset-ui/plugin-chart-table/lib/DataTable';
import * as useMountedMemo from '@superset-ui/plugin-chart-table/lib/DataTable/utils/useMountedMemo';
import { Table } from 'reactable-arc';
import QueryTable from 'src/SqlLab/components/QueryTable';
import { dataTableProps } from 'spec/javascripts/sqllab/fixtures';
import { queries } from './fixtures';
describe('QueryTable', () => {
// hack for mocking hook that implements sticky behaviour of DataTable
jest
.spyOn(useMountedMemo, 'default')
.mockImplementation(() => ({ width: 100, height: 100 }));
const mockedProps = {
...dataTableProps,
displayLimit: 10000,
queries,
};
it('is valid', () => {
expect(React.isValidElement(<QueryTable {...mockedProps} />)).toBe(true);
expect(React.isValidElement(<QueryTable />)).toBe(true);
});
it('is valid with props', () => {
expect(React.isValidElement(<QueryTable {...mockedProps} />)).toBe(true);
});
it('renders a proper table', () => {
const wrapper = shallow(<QueryTable {...mockedProps} />);
expect(wrapper.find(DataTable)).toExist();
expect(wrapper.find(DataTable).shallow().find('table')).toExist();
expect(
wrapper.find(DataTable).shallow().find('tbody').find('tr'),
).toHaveLength(2);
expect(wrapper.find(Table)).toExist();
expect(wrapper.find(Table).shallow().find('table')).toExist();
expect(wrapper.find(Table).shallow().find('table').find('Tr')).toHaveLength(
2,
);
});
});

5
superset-frontend/spec/javascripts/sqllab/fixtures.ts
View File

@@ -493,8 +493,3 @@ export const query = {
ctas: false,
cached: false,
};
export const dataTableProps = {
columns: ['dbId', 'sql'],
queries,
};