QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: simplify getExploreUrl functions (#9831)

Browse Source 
* remove payload from return signature

* Rename function and fix tests

* Lint

* fix tests

* Move useLegacyApi inquiry to exploreUtils
This commit is contained in:
Ville Brofeldt
2020-05-18 19:19:05 +03:00
committed by GitHub
parent 52285aeb04
commit 7a95c52d61
9 changed files with 57 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
superset-frontend/spec/javascripts/explore/components/SaveModal_spec.jsx
View File

@@ -140,9 +140,7 @@ describe('SaveModal', () => {
describe('saveOrOverwrite', () => {
beforeEach(() => {
sinon
.stub(exploreUtils, 'getExploreUrlAndPayload')
.callsFake(() => ({ url: 'mockURL', payload: defaultProps.form_data }));
sinon.stub(exploreUtils, 'getExploreUrl').callsFake(() => 'mockURL');
sinon.stub(defaultProps.actions, 'saveSlice').callsFake(() =>
Promise.resolve({
@@ -155,7 +153,7 @@ describe('SaveModal', () => {
});
afterEach(() => {
exploreUtils.getExploreUrlAndPayload.restore();
exploreUtils.getExploreUrl.restore();
defaultProps.actions.saveSlice.restore();
});