QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 08:34:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: simplify getExploreUrl functions (#9831)

Browse Source 
* remove payload from return signature

* Rename function and fix tests

* Lint

* fix tests

* Move useLegacyApi inquiry to exploreUtils
This commit is contained in:
Ville Brofeldt
2020-05-18 19:19:05 +03:00
committed by GitHub
parent 52285aeb04
commit 7a95c52d61
9 changed files with 57 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
superset-frontend/spec/javascripts/sqllab/ExploreResultsButton_spec.jsx
View File

@@ -177,17 +177,14 @@ describe('ExploreResultsButton', () => {
fetchMock.post(visualizeEndpoint, visualizationPayload);
beforeEach(() => {
sinon.stub(exploreUtils, 'getExploreUrlAndPayload').callsFake(() => ({
url: 'mockURL',
payload: { datasource: '107__table' },
}));
sinon.stub(exploreUtils, 'getExploreUrl').callsFake(() => 'mockURL');
sinon.spy(exploreUtils, 'exportChart');
sinon
.stub(wrapper.instance(), 'buildVizOptions')
.callsFake(() => mockOptions);
});
afterEach(() => {
exploreUtils.getExploreUrlAndPayload.restore();
exploreUtils.getExploreUrl.restore();
exploreUtils.exportChart.restore();
wrapper.instance().buildVizOptions.restore();
fetchMock.reset();