QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-11 19:05:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: simplify getExploreUrl functions (#9831)

Browse Source 
* remove payload from return signature

* Rename function and fix tests

* Lint

* fix tests

* Move useLegacyApi inquiry to exploreUtils
This commit is contained in:
Ville Brofeldt
2020-05-18 19:19:05 +03:00
committed by GitHub
parent 52285aeb04
commit 7a95c52d61
9 changed files with 57 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
superset-frontend/src/explore/components/DisplayQueryButton.jsx
View File

@@ -41,7 +41,7 @@ import { SupersetClient } from '@superset-ui/connection';
import getClientErrorObject from '../../utils/getClientErrorObject';
import CopyToClipboard from './../../components/CopyToClipboard';
import { getExploreUrlAndPayload } from '../exploreUtils';
import { getExploreUrl } from '../exploreUtils';
import Loading from '../../components/Loading';
import ModalTrigger from './../../components/ModalTrigger';
@@ -89,13 +89,13 @@ export class DisplayQueryButton extends React.PureComponent {
}
beforeOpen(endpointType) {
this.setState({ isLoading: true });
const { url, payload } = getExploreUrlAndPayload({
const url = getExploreUrl({
formData: this.props.latestQueryFormData,
endpointType,
});
SupersetClient.post({
url,
postPayload: { form_data: payload },
postPayload: { form_data: this.props.latestQueryFormData },
})
.then(({ json }) => {
this.setState({