QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Change get_table_names/get_view_names return type (#22085)

Browse Source
This commit is contained in:
John Bodley
2022-11-18 12:41:21 -08:00
committed by GitHub
parent e990690dde
commit 7e54b88a51
12 changed files with 76 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/integration_tests/db_engine_specs/base_engine_spec_tests.py
View File

@@ -229,11 +229,11 @@ class TestDbEngineSpecs(TestDbEngineSpec):
""" Make sure base engine spec removes schema name from table name
ie. when try_remove_schema_from_table_name == True. """
base_result_expected = ["table", "table_2"]
base_result_expected = {"table", "table_2"}
base_result = BaseEngineSpec.get_table_names(
database=mock.ANY, schema="schema", inspector=inspector
)
self.assertListEqual(base_result_expected, base_result)
assert base_result_expected == base_result
@pytest.mark.usefixtures("load_energy_table_with_slice")
def test_column_datatype_to_string(self):

4
tests/integration_tests/db_engine_specs/postgres_tests.py
View File

@@ -45,11 +45,11 @@ class TestPostgresDbEngineSpec(TestDbEngineSpec):
inspector.get_table_names = mock.Mock(return_value=["schema.table", "table_2"])
inspector.get_foreign_table_names = mock.Mock(return_value=["table_3"])
pg_result_expected = ["schema.table", "table_2", "table_3"]
pg_result_expected = {"schema.table", "table_2", "table_3"}
pg_result = PostgresEngineSpec.get_table_names(
database=mock.ANY, schema="schema", inspector=inspector
)
self.assertListEqual(pg_result_expected, pg_result)
assert pg_result_expected == pg_result
def test_time_exp_literal_no_grain(self):
"""

10
tests/integration_tests/db_engine_specs/presto_tests.py
View File

@@ -56,7 +56,7 @@ class TestPrestoDbEngineSpec(TestDbEngineSpec):
).strip(),
{"schema": schema},
)
assert result == ["a", "d"]
assert result == {"a", "d"}
def test_get_view_names_without_schema(self):
database = mock.MagicMock()
@@ -77,7 +77,7 @@ class TestPrestoDbEngineSpec(TestDbEngineSpec):
).strip(),
{},
)
assert result == ["a", "d"]
assert result == {"a", "d"}
def verify_presto_column(self, column, expected_results):
inspector = mock.Mock()
@@ -670,10 +670,10 @@ class TestPrestoDbEngineSpec(TestDbEngineSpec):
mock_get_view_names,
mock_get_table_names,
):
mock_get_view_names.return_value = ["view1", "view2"]
mock_get_table_names.return_value = ["table1", "table2", "view1", "view2"]
mock_get_view_names.return_value = {"view1", "view2"}
mock_get_table_names.return_value = {"table1", "table2", "view1", "view2"}
tables = PrestoEngineSpec.get_table_names(mock.Mock(), mock.Mock(), None)
assert tables == ["table1", "table2"]
assert tables == {"table1", "table2"}
def test_get_full_name(self):
names = [