QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Change get_table_names/get_view_names return type (#22085)

Browse Source
This commit is contained in:
John Bodley
2022-11-18 12:41:21 -08:00
committed by GitHub
parent e990690dde
commit 7e54b88a51
12 changed files with 76 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/integration_tests/db_engine_specs/presto_tests.py
View File

@@ -56,7 +56,7 @@ class TestPrestoDbEngineSpec(TestDbEngineSpec):
).strip(),
{"schema": schema},
)
assert result == ["a", "d"]
assert result == {"a", "d"}
def test_get_view_names_without_schema(self):
database = mock.MagicMock()
@@ -77,7 +77,7 @@ class TestPrestoDbEngineSpec(TestDbEngineSpec):
).strip(),
{},
)
assert result == ["a", "d"]
assert result == {"a", "d"}
def verify_presto_column(self, column, expected_results):
inspector = mock.Mock()
@@ -670,10 +670,10 @@ class TestPrestoDbEngineSpec(TestDbEngineSpec):
mock_get_view_names,
mock_get_table_names,
):
mock_get_view_names.return_value = ["view1", "view2"]
mock_get_table_names.return_value = ["table1", "table2", "view1", "view2"]
mock_get_view_names.return_value = {"view1", "view2"}
mock_get_table_names.return_value = {"table1", "table2", "view1", "view2"}
tables = PrestoEngineSpec.get_table_names(mock.Mock(), mock.Mock(), None)
assert tables == ["table1", "table2"]
assert tables == {"table1", "table2"}
def test_get_full_name(self):
names = [