QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

quote column name if db requires (#15465)

Browse Source 
Co-authored-by: hughhhh <hughmil3s@gmail.com>
This commit is contained in:
Elizabeth Thompson
2021-07-02 10:48:24 -07:00
committed by GitHub
parent 68704a595b
commit 80b8df0673
3 changed files with 89 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
tests/integration_tests/db_engine_specs/snowflake_tests.py
View File

@@ -16,6 +16,8 @@
# under the License.
import json
from sqlalchemy import column
from superset.db_engine_specs.snowflake import SnowflakeEngineSpec
from superset.errors import ErrorLevel, SupersetError, SupersetErrorType
from superset.models.core import Database
@@ -23,6 +25,20 @@ from tests.integration_tests.db_engine_specs.base_tests import TestDbEngineSpec
class TestSnowflakeDbEngineSpec(TestDbEngineSpec):
def test_snowflake_sqla_column_label(self):
"""
DB Eng Specs (snowflake): Test column label
"""
test_cases = {
"Col": "Col",
"SUM(x)": "SUM(x)",
"SUM[x]": "SUM[x]",
"12345_col": "12345_col",
}
for original, expected in test_cases.items():
actual = SnowflakeEngineSpec.make_label_compatible(column(original).name)
self.assertEqual(actual, expected)
def test_convert_dttm(self):
dttm = self.get_dttm()