QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: method for dynamic allows_alias_in_select (#25882)

Browse Source
This commit is contained in:
Beto Dealmeida
2023-11-07 14:28:28 -05:00
committed by GitHub
parent 3ee22667a7
commit 80caba3fd1
5 changed files with 67 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
tests/unit_tests/db_engine_specs/test_dremio.py
View File

@@ -18,6 +18,7 @@ from datetime import datetime
from typing import Optional
import pytest
from pytest_mock import MockerFixture
from tests.unit_tests.db_engine_specs.utils import assert_convert_dttm
from tests.unit_tests.fixtures.common import dttm
@@ -40,3 +41,18 @@ def test_convert_dttm(
from superset.db_engine_specs.dremio import DremioEngineSpec as spec
assert_convert_dttm(spec, target_type, expected_result, dttm)
def test_get_allows_alias_in_select(mocker: MockerFixture) -> None:
from superset.db_engine_specs.dremio import DremioEngineSpec
database = mocker.MagicMock()
database.get_extra.return_value = {}
assert DremioEngineSpec.get_allows_alias_in_select(database) is True
database.get_extra.return_value = {"version": "24.1.0"}
assert DremioEngineSpec.get_allows_alias_in_select(database) is True
database.get_extra.return_value = {"version": "24.0.0"}
assert DremioEngineSpec.get_allows_alias_in_select(database) is False