QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Altered button crashing and title not updating on Explore view (#11960)

Browse Source 
* Fix chart name not updating

* Fix AlteredSliceTag crashing

* Update name after it's changed in another modal
This commit is contained in:
Kamil Gabryjelski
2021-01-05 01:14:06 +01:00
committed by GitHub
parent 8ecf82de5a
commit 811e1b273b
4 changed files with 14 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
superset-frontend/spec/javascripts/components/AlteredSliceTag_spec.jsx
View File

@@ -23,8 +23,8 @@ import { getChartControlPanelRegistry } from '@superset-ui/core';
import AlteredSliceTag from 'src/components/AlteredSliceTag';
import ModalTrigger from 'src/components/ModalTrigger';
import TooltipWrapper from 'src/components/TooltipWrapper';
import ListView from 'src/components/ListView';
import TableCollection from 'src/components/dataViewCommon/TableCollection';
import TableView from 'src/components/TableView';
import {
defaultProps,
@@ -34,7 +34,7 @@ import {
} from './fixtures/AlteredSliceTag';
const getTableWrapperFromModalBody = modalBody =>
modalBody.find(ListView).find(TableCollection);
modalBody.find(TableView).find(TableCollection);
describe('AlteredSliceTag', () => {
let wrapper;
@@ -110,7 +110,7 @@ describe('AlteredSliceTag', () => {
const modalBody = mount(
<div>{wrapper.instance().renderModalBody()}</div>,
);
expect(modalBody.find(ListView)).toHaveLength(1);
expect(modalBody.find(TableView)).toHaveLength(1);
});
it('renders a thead', () => {