QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-07 18:35:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: hide datasource legacy based on featureflag (#11371)

Browse Source
This commit is contained in:
Hugh A. Miles II
2020-10-26 17:31:29 -07:00
committed by GitHub
parent 2227b13b52
commit 81f77fd28e
4 changed files with 63 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
superset-frontend/spec/javascripts/datasource/DatasourceModal_spec.jsx
View File

@@ -29,6 +29,7 @@ import { supersetTheme, ThemeProvider } from '@superset-ui/core';
import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint';
import DatasourceModal from 'src/datasource/DatasourceModal';
import DatasourceEditor from 'src/datasource/DatasourceEditor';
import * as featureFlags from 'src/featureFlags';
import mockDatasource from '../../fixtures/mockDatasource';
const mockStore = configureStore([thunk]);
@@ -61,12 +62,19 @@ async function mountAndWait(props = mockedProps) {
describe('DatasourceModal', () => {
let wrapper;
let isFeatureEnabledMock;
beforeEach(async () => {
isFeatureEnabledMock = jest
.spyOn(featureFlags, 'isFeatureEnabled')
.mockReturnValue(true);
fetchMock.reset();
wrapper = await mountAndWait();
});
afterAll(() => {
isFeatureEnabledMock.restore();
});
it('renders', () => {
expect(wrapper.find(DatasourceModal)).toExist();
});
@@ -98,4 +106,35 @@ describe('DatasourceModal', () => {
expected,
); /* eslint no-underscore-dangle: 0 */
});
it('renders a legacy data source btn', () => {
expect(
wrapper.find('button[data-test="datasource-modal-legacy-edit"]'),
).toExist();
});
});
describe('DatasourceModal without legacy data btn', () => {
let wrapper;
let isFeatureEnabledMock;
beforeEach(async () => {
isFeatureEnabledMock = jest
.spyOn(featureFlags, 'isFeatureEnabled')
.mockReturnValue(false);
fetchMock.reset();
wrapper = await mountAndWait();
});
afterAll(() => {
isFeatureEnabledMock.restore();
});
it('hides legacy data source btn', () => {
isFeatureEnabledMock = jest
.spyOn(featureFlags, 'isFeatureEnabled')
.mockReturnValue(false);
expect(
wrapper.find('button[data-test="datasource-modal-legacy-edit"]'),
).not.toExist();
});
});