QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-07 17:04:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Call props.onChange only when closing filter (#4003)

Browse Source
This commit is contained in:
Beto Dealmeida
2017-12-05 11:17:12 -08:00
committed by Maxime Beauchemin
parent 72627b1761
commit 823f306f24
1 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
superset/assets/javascripts/explore/components/controls/DateFilterControl.jsx
View File

@@ -63,17 +63,6 @@ export default class DateFilterControl extends React.Component {
onNumberChange(event) {
this.setState({ num: event.target.value }, this.onChange);
}
onChange() {
let val;
if (this.state.type === 'rel') {
val = `${this.state.num} ${this.state.grain} ${this.state.rel}`;
} else if (this.state.type === 'fix') {
val = this.state.dttm;
} else if (this.state.type === 'free') {
val = this.state.free;
}
this.props.onChange(val);
}
onFreeChange(event) {
this.setState({ free: event.target.value }, this.onChange);
}
@@ -88,6 +77,15 @@ export default class DateFilterControl extends React.Component {
this.setState({ dttm: dttm.format().substring(0, 19) }, this.onChange);
}
close() {
let val;
if (this.state.type === 'rel') {
val = `${this.state.num} ${this.state.grain} ${this.state.rel}`;
} else if (this.state.type === 'fix') {
val = this.state.dttm;
} else if (this.state.type === 'free') {
val = this.state.free;
}
this.props.onChange(val);
this.refs.trigger.hide();
}
renderPopover() {