QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-17 23:25:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

[WiP] Cleanup & fix URL scheme for the explore view (#4490)

Browse Source 
* Improve URLs

* Fix js tests
This commit is contained in:
Maxime Beauchemin
2018-02-27 15:08:06 -08:00
committed by Grace Guo
parent bcca1717f2
commit 83524f97d7
9 changed files with 114 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
superset/assets/spec/javascripts/explore/utils_spec.jsx
View File

@@ -27,7 +27,7 @@ describe('utils', () => {
});
compareURI(
URI(url),
URI('/superset/explore/table/1/'),
URI('/superset/explore/'),
);
expect(payload).to.deep.equals(formData);
});
@@ -40,7 +40,7 @@ describe('utils', () => {
});
compareURI(
URI(url),
URI('/superset/explore_json/table/1/'),
URI('/superset/explore_json/'),
);
expect(payload).to.deep.equals(formData);
});
@@ -53,7 +53,7 @@ describe('utils', () => {
});
compareURI(
URI(url),
URI('/superset/explore_json/table/1/')
URI('/superset/explore_json/')
.search({ force: 'true' }),
);
expect(payload).to.deep.equals(formData);
@@ -67,7 +67,7 @@ describe('utils', () => {
});
compareURI(
URI(url),
URI('/superset/explore_json/table/1/')
URI('/superset/explore_json/')
.search({ csv: 'true' }),
);
expect(payload).to.deep.equals(formData);
@@ -81,7 +81,7 @@ describe('utils', () => {
});
compareURI(
URI(url),
URI('/superset/explore/table/1/')
URI('/superset/explore/')
.search({ standalone: 'true' }),
);
expect(payload).to.deep.equals(formData);
@@ -95,7 +95,7 @@ describe('utils', () => {
});
compareURI(
URI(url),
URI('/superset/explore_json/table/1/')
URI('/superset/explore_json/')
.search({ foo: 'bar' }),
);
expect(payload).to.deep.equals(formData);
@@ -109,7 +109,7 @@ describe('utils', () => {
});
compareURI(
URI(url),
URI('/superset/explore_json/table/1/')
URI('/superset/explore_json/')
.search({ foo: 'bar' }),
);
expect(payload).to.deep.equals(formData);
@@ -123,7 +123,7 @@ describe('utils', () => {
});
compareURI(
URI(url),
URI('/superset/explore_json/table/1/')
URI('/superset/explore_json/')
.search({ foo: 'bar' }),
);
expect(payload).to.deep.equals(formData);
@@ -134,7 +134,7 @@ describe('utils', () => {
it('generates proper base url with form_data', () => {
compareURI(
URI(getExploreLongUrl(formData, 'base')),
URI('/superset/explore/table/1/').search({ form_data: sFormData }),
URI('/superset/explore/').search({ form_data: sFormData }),
);
});
});