refactor: Ensure Flask framework leverages the Flask-SQLAlchemy session (Phase II) (#26909)

This commit is contained in:
John Bodley
2024-02-14 06:20:15 +13:00
committed by GitHub
parent 827864b939
commit 847ed3f5b0
96 changed files with 656 additions and 730 deletions

View File

@@ -230,15 +230,14 @@ class TestGuestUserDatasourceAccess(SupersetTestCase):
schema=get_example_default_schema(),
sql="select 123 as intcol, 'abc' as strcol",
)
session = db.session
session.add(dataset)
session.commit()
db.session.add(dataset)
db.session.commit()
yield dataset
# rollback
session.delete(dataset)
session.commit()
db.session.delete(dataset)
db.session.commit()
def setUp(self) -> None:
self.dash = self.get_dash_by_slug("births")
@@ -258,11 +257,9 @@ class TestGuestUserDatasourceAccess(SupersetTestCase):
],
}
)
self.chart = self.get_slice("Girls", db.session, expunge_from_session=False)
self.chart = self.get_slice("Girls", expunge_from_session=False)
self.datasource = self.chart.datasource
self.other_chart = self.get_slice(
"Treemap", db.session, expunge_from_session=False
)
self.other_chart = self.get_slice("Treemap", expunge_from_session=False)
self.other_datasource = self.other_chart.datasource
self.native_filter_datasource = (
db.session.query(SqlaTable).filter_by(table_name="dummy_sql_table").first()