QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Ensure Flask framework leverages the Flask-SQLAlchemy session (Phase II) (#26909)

Browse Source
This commit is contained in:
John Bodley
2024-02-14 06:20:15 +13:00
committed by GitHub
parent 827864b939
commit 847ed3f5b0
96 changed files with 656 additions and 730 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/unit_tests/dashboards/dao_tests.py
View File

@@ -42,12 +42,10 @@ def session_with_data(session: Session) -> Iterator[Session]:
session.rollback()
def test_add_favorite(session_with_data: Session) -> None:
def test_add_favorite(session: Session) -> None:
from superset.daos.dashboard import DashboardDAO
dashboard = DashboardDAO.find_by_id(
100, session=session_with_data, skip_base_filter=True
)
dashboard = DashboardDAO.find_by_id(100, skip_base_filter=True)
if not dashboard:
return
assert len(DashboardDAO.favorited_ids([dashboard])) == 0
@@ -59,12 +57,10 @@ def test_add_favorite(session_with_data: Session) -> None:
assert len(DashboardDAO.favorited_ids([dashboard])) == 1
def test_remove_favorite(session_with_data: Session) -> None:
def test_remove_favorite(session: Session) -> None:
from superset.daos.dashboard import DashboardDAO
dashboard = DashboardDAO.find_by_id(
100, session=session_with_data, skip_base_filter=True
)
dashboard = DashboardDAO.find_by_id(100, skip_base_filter=True)
if not dashboard:
return
assert len(DashboardDAO.favorited_ids([dashboard])) == 0