QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 08:34:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

make config method optional (#14668)

Browse Source
This commit is contained in:
AAfghahi
2021-05-17 17:09:20 -04:00
committed by GitHub
parent 3ad8b546e6
commit 852842028a
2 changed files with 28 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
tests/databases/api_tests.py
View File

@@ -275,35 +275,36 @@ class TestDatabaseApi(SupersetTestCase):
}
assert rv.status_code == 400
def test_create_database_no_configuration_method(self):
"""
Database API: Test create with no config method.
"""
extra = {
"metadata_params": {},
"engine_params": {},
"metadata_cache_timeout": {},
"schemas_allowed_for_csv_upload": [],
}
# add this test back in when config method becomes required for creation.
# def test_create_database_no_configuration_method(self):
# """
# Database API: Test create with no config method.
# """
# extra = {
# "metadata_params": {},
# "engine_params": {},
# "metadata_cache_timeout": {},
# "schemas_allowed_for_csv_upload": [],
# }
self.login(username="admin")
example_db = get_example_database()
if example_db.backend == "sqlite":
return
database_data = {
"database_name": "test-create-database",
"sqlalchemy_uri": example_db.sqlalchemy_uri_decrypted,
"server_cert": None,
"extra": json.dumps(extra),
}
# self.login(username="admin")
# example_db = get_example_database()
# if example_db.backend == "sqlite":
# return
# database_data = {
# "database_name": "test-create-database",
# "sqlalchemy_uri": example_db.sqlalchemy_uri_decrypted,
# "server_cert": None,
# "extra": json.dumps(extra),
# }
uri = "api/v1/database/"
rv = self.client.post(uri, json=database_data)
response = json.loads(rv.data.decode("utf-8"))
assert response == {
"message": {"configuration_method": ["Missing data for required field."]}
}
assert rv.status_code == 400
# uri = "api/v1/database/"
# rv = self.client.post(uri, json=database_data)
# response = json.loads(rv.data.decode("utf-8"))
# assert response == {
# "message": {"configuration_method": ["Missing data for required field."]}
# }
# assert rv.status_code == 400
def test_create_database_server_cert_validate(self):
"""