QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(explore): Disable saved metric name edit in Metric popover (#12582)

Browse Source
This commit is contained in:
Kamil Gabryjelski
2021-01-19 21:28:55 +01:00
committed by GitHub
parent 862ddd9cb4
commit 853d34beba
8 changed files with 99 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
superset-frontend/spec/javascripts/explore/components/AdhocMetricEditPopoverTitle_spec.jsx
View File

@@ -46,15 +46,25 @@ describe('AdhocMetricEditPopoverTitle', () => {
expect(wrapper.find(Tooltip)).toExist();
expect(
wrapper.find('[data-test="AdhocMetricEditTitle#trigger"]').text(),
).toBe('My Metric\xa0');
).toBe(`${title.label}\xa0`);
});
it('transfers to edit mode when clicked', () => {
const { wrapper } = setup();
expect(wrapper.state('isEditable')).toBe(false);
expect(wrapper.state('isEditMode')).toBe(false);
wrapper
.find('[data-test="AdhocMetricEditTitle#trigger"]')
.simulate('click');
expect(wrapper.state('isEditable')).toBe(true);
expect(wrapper.state('isEditMode')).toBe(true);
});
it('Render non-interactive span with title when edit is disabled', () => {
const { wrapper } = setup({ isEditDisabled: true });
expect(
wrapper.find('[data-test="AdhocMetricTitle"]').exists(),
).toBeTruthy();
expect(
wrapper.find('[data-test="AdhocMetricEditTitle#trigger"]').exists(),
).toBeFalsy();
});
});