QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 00:24:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(explore): fix y-axis lower bound 0 value (#15091)

Browse Source
This commit is contained in:
Yaozong Liu
2021-06-13 11:24:39 +08:00
committed by GitHub
parent 8e6a5a6f52
commit 856a2bd5ed
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
superset-frontend/spec/javascripts/explore/components/BoundsControl_spec.jsx
View File

@@ -51,3 +51,12 @@ test('calls onChange with correct values', async () => {
expect(defaultProps.onChange).toHaveBeenLastCalledWith([1, 2]), expect(defaultProps.onChange).toHaveBeenLastCalledWith([1, 2]),
); );
}); });
test('receives 0 value', async () => {
render(<BoundsControl {...defaultProps} />);
const minInput = screen.getAllByRole('spinbutton')[0];
userEvent.type(minInput, '0');
await waitFor(() =>
expect(defaultProps.onChange).toHaveBeenLastCalledWith([0, null]),
);
});

4
superset-frontend/src/explore/components/controls/BoundsControl.jsx
View File

@@ -97,8 +97,8 @@ export default class BoundsControl extends React.Component {
onChange() { onChange() {
const mm = this.state.minMax; const mm = this.state.minMax;
const min = parseFloat(mm[0]) || null; const min = Number.isNaN(parseFloat(mm[0])) ? null : parseFloat(mm[0]);
const max = parseFloat(mm[1]) || null; const max = Number.isNaN(parseFloat(mm[1])) ? null : parseFloat(mm[1]);
this.props.onChange([min, max]); this.props.onChange([min, max]);
} }