QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: is_temporal should be overridden by is_dttm value (#11429)

Browse Source
This commit is contained in:
Ville Brofeldt
2020-10-27 07:22:27 +02:00
committed by GitHub
parent 94e0f0cc2a
commit 8575439f48
3 changed files with 27 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/sqla_models_tests.py
View File

@@ -44,6 +44,18 @@ class TestDatabaseModel(SupersetTestCase):
col = TableColumn(column_name="__not_time", type="INTEGER", table=tbl)
self.assertEqual(col.is_temporal, False)
def test_temporal_varchar(self):
"""Ensure a column with is_dttm set to true evaluates to is_temporal == True"""
database = get_example_database()
tbl = SqlaTable(table_name="test_tbl", database=database)
col = TableColumn(column_name="ds", type="VARCHAR", table=tbl)
# by default, VARCHAR should not be assumed to be temporal
assert col.is_temporal is False
# changing to `is_dttm = True`, calling `is_temporal` should return True
col.is_dttm = True
assert col.is_temporal is True
def test_db_column_types(self):
test_cases: Dict[str, DbColumnType] = {
# string