QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: add None checking to cast_to_num (#10584)

Browse Source 
* fix: add None checking to cast_to_num

* fix doctest
This commit is contained in:
Ville Brofeldt
2020-08-12 19:58:14 +03:00
committed by GitHub
parent a8197976fe
commit 85c0cad816
2 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/utils_tests.py
View File

@@ -38,6 +38,7 @@ from superset.models.core import Database, Log
from superset.utils.cache_manager import CacheManager
from superset.utils.core import (
base_json_conv,
cast_to_num,
convert_legacy_filters_into_adhoc,
create_ssl_cert_file,
format_timedelta,
@@ -1368,6 +1369,14 @@ class TestUtils(SupersetTestCase):
self.assertRaises(marshmallow.ValidationError, validator, "qwerty")
self.assertRaises(marshmallow.ValidationError, validator, 4)
def test_cast_to_num(self) -> None:
assert cast_to_num("5") == 5
assert cast_to_num("5.2") == 5.2
assert cast_to_num(10) == 10
assert cast_to_num(10.1) == 10.1
assert cast_to_num(None) is None
assert cast_to_num("this is not a string") is None
def test_get_form_data_token(self):
assert get_form_data_token({"token": "token_abcdefg1"}) == "token_abcdefg1"
generated_token = get_form_data_token({})