QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(explore): timestamp format when copy datatable to clipboard (#17166)

Browse Source 
* fix(explore): timestamp format when copy datatable to clipboard

* Fix test

* Fix test

* Use translation for aria label

* Memoize stringified cells

* Fix test
This commit is contained in:
Kamil Gabryjelski
2021-10-21 16:05:14 +02:00
committed by GitHub
parent e5a03423f9
commit 860e481a97
4 changed files with 75 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
superset-frontend/src/explore/components/DataTableControl/index.tsx
View File

@@ -27,10 +27,7 @@ import {
SLOW_DEBOUNCE,
} from 'src/constants';
import Button from 'src/components/Button';
import {
applyFormattingToTabularData,
prepareCopyToClipboardTabularData,
} from 'src/utils/common';
import { prepareCopyToClipboardTabularData } from 'src/utils/common';
import CopyToClipboard from 'src/components/CopyToClipboard';
import RowCountLabel from 'src/explore/components/RowCountLabel';
@@ -48,7 +45,7 @@ export const CopyButton = styled(Button)`
`;
const CopyNode = (
<CopyButton buttonSize="xsmall">
<CopyButton buttonSize="xsmall" aria-label={t('Copy')}>
<i className="fa fa-clipboard" />
</CopyButton>
);
@@ -103,18 +100,26 @@ export const RowCount = ({
export const useFilteredTableData = (
filterText: string,
data?: Record<string, any>[],
) =>
useMemo(() => {
) => {
const rowsAsStrings = useMemo(
() =>
data?.map((row: Record<string, any>) =>
Object.values(row).map(value => value?.toString().toLowerCase()),
) ?? [],
[data],
);
return useMemo(() => {
if (!data?.length) {
return [];
}
const formattedData = applyFormattingToTabularData(data);
return formattedData.filter((row: Record<string, any>) =>
Object.values(row).some(value =>
value?.toString().toLowerCase().includes(filterText.toLowerCase()),
return data.filter((_, index: number) =>
rowsAsStrings[index].some(value =>
value?.includes(filterText.toLowerCase()),
),
);
}, [data, filterText]);
}, [data, filterText, rowsAsStrings]);
};
export const useTableColumns = (
colnames?: string[],