QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 19:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: chart disappears in standalone slice (#12606)

Browse Source
This commit is contained in:
Duy Nguyen Hoang
2021-01-20 02:56:24 +07:00
committed by GitHub
parent 68fe2208ba
commit 862ddd9cb4
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
superset-frontend/src/explore/components/ExploreChartPanel.jsx
View File

@@ -203,6 +203,11 @@ const ExploreChartPanel = props => {
[chartRef, renderChart], [chartRef, renderChart],
); );
const standaloneChartBody = useMemo(
() => <div ref={chartRef}>{renderChart()}</div>,
[chartRef, renderChart],
);
if (props.standalone) { if (props.standalone) {
// dom manipulation hack to get rid of the boostrap theme's body background // dom manipulation hack to get rid of the boostrap theme's body background
const standaloneClass = 'background-transparent'; const standaloneClass = 'background-transparent';
@@ -210,7 +215,7 @@ const ExploreChartPanel = props => {
if (!bodyClasses.includes(standaloneClass)) { if (!bodyClasses.includes(standaloneClass)) {
document.body.className += ` ${standaloneClass}`; document.body.className += ` ${standaloneClass}`;
} }
return renderChart(); return standaloneChartBody;
} }
const header = ( const header = (

2
superset/charts/api.py
View File

@@ -557,7 +557,7 @@ class ChartRestApi(BaseSupersetModelRestApi):
try: try:
json_body = json.loads(request.form["form_data"]) json_body = json.loads(request.form["form_data"])
except (TypeError, json.JSONDecodeError): except (TypeError, json.JSONDecodeError):
json_body = None pass
if json_body is None: if json_body is None:
return self.response_400(message=_("Request is not JSON")) return self.response_400(message=_("Request is not JSON"))