diff --git a/superset-frontend/src/SqlLab/components/QueryTable/index.tsx b/superset-frontend/src/SqlLab/components/QueryTable/index.tsx index fda383430d4..d97a264a2de 100644 --- a/superset-frontend/src/SqlLab/components/QueryTable/index.tsx +++ b/superset-frontend/src/SqlLab/components/QueryTable/index.tsx @@ -28,7 +28,7 @@ import { } from '@superset-ui/core/components'; import ProgressBar from '@superset-ui/core/components/ProgressBar'; import { t } from '@apache-superset/core/translation'; -import { QueryResponse, QueryState } from '@superset-ui/core'; +import { QueryResponse } from '@superset-ui/core'; import { useTheme } from '@apache-superset/core/theme'; import { shallowEqual, useSelector } from 'react-redux'; import { useAppDispatch } from 'src/SqlLab/hooks/useAppDispatch'; @@ -406,24 +406,12 @@ const QueryTable = ({ modalBody={ selectedQuery ? ( - {(() => { - const height = - reduxQueries[selectedQuery.id]?.state === - QueryState.Success && - reduxQueries[selectedQuery.id]?.results - ? Math.floor(window.innerHeight * 0.5) - : undefined; - return ( - - ); - })()} + ) : null } diff --git a/superset-frontend/src/SqlLab/components/QueryTable/styles.ts b/superset-frontend/src/SqlLab/components/QueryTable/styles.ts index 4424becee68..377575aede2 100644 --- a/superset-frontend/src/SqlLab/components/QueryTable/styles.ts +++ b/superset-frontend/src/SqlLab/components/QueryTable/styles.ts @@ -44,4 +44,5 @@ export const ModalResultSetWrapper = styled.div` display: flex; flex-direction: column; overflow: hidden; + height: 500px; `; diff --git a/superset-frontend/src/SqlLab/components/ResultSet/index.tsx b/superset-frontend/src/SqlLab/components/ResultSet/index.tsx index cfd8ea6832e..8f8600a5343 100644 --- a/superset-frontend/src/SqlLab/components/ResultSet/index.tsx +++ b/superset-frontend/src/SqlLab/components/ResultSet/index.tsx @@ -108,14 +108,12 @@ export interface ResultSetProps { csv?: boolean; database?: Record; displayLimit: number; - height?: number; queryId: string; search?: boolean; showSql?: boolean; showSqlInline?: boolean; visualize?: boolean; defaultQueryLimit: number; - useFixedHeight?: boolean; } const ResultContainer = styled.div` @@ -166,14 +164,12 @@ const ResultSet = ({ csv = true, database = {}, displayLimit, - height, queryId, search = true, showSql = false, showSqlInline = false, visualize = true, defaultQueryLimit, - useFixedHeight = false, }: ResultSetProps) => { const streamingThreshold = useSelector( (state: SqlLabRootState) => @@ -774,22 +770,18 @@ const ResultSet = ({ /> )} - {useFixedHeight && height !== undefined ? ( - - ) : ( -
- - {({ height: autoHeight }) => ( - - )} - -
- )} +
+ + {({ height: autoHeight }) => ( + + )} + +