QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-07 18:35:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove shadow write of new sip 68 dataset models (#21986)

Browse Source
This commit is contained in:
Elizabeth Thompson
2022-11-14 09:55:53 -08:00
committed by GitHub
parent 824dc7188b
commit 86d52fcbc4
6 changed files with 37 additions and 1738 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/unit_tests/datasource/dao_tests.py
View File

@@ -144,15 +144,13 @@ def test_get_datasource_sl_table(session_with_data: Session) -> None:
from superset.datasource.dao import DatasourceDAO
from superset.tables.models import Table
# todo(hugh): This will break once we remove the dual write
# update the datsource_id=1 and this will pass again
result = DatasourceDAO.get_datasource(
datasource_type=DatasourceType.SLTABLE,
datasource_id=2,
datasource_id=1,
session=session_with_data,
)
assert result.id == 2
assert result.id == 1
assert isinstance(result, Table)
@@ -160,15 +158,13 @@ def test_get_datasource_sl_dataset(session_with_data: Session) -> None:
from superset.datasets.models import Dataset
from superset.datasource.dao import DatasourceDAO
# todo(hugh): This will break once we remove the dual write
# update the datsource_id=1 and this will pass again
result = DatasourceDAO.get_datasource(
datasource_type=DatasourceType.DATASET,
datasource_id=2,
datasource_id=1,
session=session_with_data,
)
assert result.id == 2
assert result.id == 1
assert isinstance(result, Dataset)