QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-29 20:29:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(reports): fix stale warning assertions after timeout message change

Browse Source 
- Update assert_any_call in per-tile spinner timeout test to include the
  new (load_wait=%ss) suffix and value
- Update assert_any_call in webdriver spinner timeout test to include the
  new (SCREENSHOT_LOAD_WAIT=%ss) suffix and value
- Fix test_per_tile_non_timeout_exceptions: RuntimeError is caught by the
  outer take_tiled_screenshot handler and returns None, not re-raised;
  rename and update assertion to match actual behavior

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Elizabeth Thompson
2026-05-06 19:53:23 +00:00
committed by Sophie
parent 8d7ffac945
commit 86d705dd01
2 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/unit_tests/utils/webdriver_test.py
View File

@@ -753,8 +753,9 @@ class TestWebDriverPlaywrightErrorHandling:
assert exc_info.value is timeout
mock_logger.warning.assert_any_call(
"Timed out waiting for charts to load at url %s",
"Timed out waiting for charts to load at url %s (SCREENSHOT_LOAD_WAIT=%ss)",
"http://example.com",
60,
)
@patch("superset.utils.webdriver.PLAYWRIGHT_AVAILABLE", True)