QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 16:44:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: should update last_modified_time in client-side after save dash (#11305)

Browse Source
This commit is contained in:
Grace Guo
2020-10-16 10:54:35 -07:00
committed by GitHub
parent afee008a10
commit 8863c939ad
7 changed files with 37 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
superset-frontend/spec/javascripts/dashboard/reducers/dashboardState_spec.js
View File

@@ -120,14 +120,29 @@ describe('dashboardState reducer', () => {
});
it('should set unsaved changes, max undo history, and editMode to false on save', () => {
const result = dashboardStateReducer(
{ hasUnsavedChanges: true },
{ type: ON_SAVE },
);
expect(result.hasUnsavedChanges).toBe(false);
expect(result.maxUndoHistoryExceeded).toBe(false);
expect(result.editMode).toBe(false);
expect(result.updatedColorScheme).toBe(false);
});
it('should set lastModifiedTime on save', () => {
const lastModifiedTime = new Date().getTime() / 1000;
dashboardStateReducer(
{
lastModifiedTime,
},
{},
);
expect(
dashboardStateReducer({ hasUnsavedChanges: true }, { type: ON_SAVE }),
).toEqual({
hasUnsavedChanges: false,
maxUndoHistoryExceeded: false,
editMode: false,
updatedColorScheme: false,
});
dashboardStateReducer({ hasUnsavedChanges: true }, { type: ON_SAVE })
.lastModifiedTime,
).toBeGreaterThanOrEqual(lastModifiedTime);
});
it('should clear focused filter field', () => {