QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-06-06 16:19:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

[explore-v2] handle field overrides (#1535)

Browse Source 
* pass all props to *Field components

* s/fieldSetOverrides/fieldOverrides

* handle field overrides
This commit is contained in:
Alanna Scott
2016-11-03 13:38:17 -07:00
committed by GitHub
parent d9b49ca2bc
commit 88b1f956c7
4 changed files with 43 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
caravel/assets/javascripts/explorev2/components/ControlPanelsContainer.jsx
View File

@@ -18,12 +18,6 @@ const defaultProps = {
vizType: null,
};
function getSectionsToRender(vizSections) {
const { datasourceAndVizType, sqlClause } = commonControlPanelSections;
const sectionsToRender = [datasourceAndVizType].concat(vizSections, sqlClause);
return sectionsToRender;
}
class ControlPanelsContainer extends React.Component {
componentWillMount() {
const { datasourceId, datasourceType } = this.props;
@@ -32,22 +26,36 @@ class ControlPanelsContainer extends React.Component {
}
}
render() {
sectionsToRender() {
const viz = visTypes[this.props.vizType];
const sectionsToRender = getSectionsToRender(viz.controlPanelSections);
const { datasourceAndVizType, sqlClause } = commonControlPanelSections;
const sectionsToRender = [datasourceAndVizType].concat(viz.controlPanelSections, sqlClause);
return sectionsToRender;
}
fieldOverrides() {
const viz = visTypes[this.props.vizType];
return viz.fieldOverrides;
}
render() {
return (
<Panel>
<div className="scrollbar-container">
<div className="scrollbar-content">
{sectionsToRender.map((section) => (
{this.sectionsToRender().map((section) => (
<ControlPanelSection
key={section.label}
label={section.label}
tooltip={section.description}
>
{section.fieldSetRows.map((fieldSets, i) => (
<FieldSetRow key={`${section.label}-fieldSetRow-${i}`} fieldSets={fieldSets} />
<FieldSetRow
key={`${section.label}-fieldSetRow-${i}`}
fieldSets={fieldSets}
fieldOverrides={this.fieldOverrides()}
/>
))}
</ControlPanelSection>
))}