QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(reports): Clear last value when state is WORKING (#19941)

Browse Source 
* fix(reports): Clear last value when state is WORKING

* Update cbe71abde154_fix_report_schedule_and_log.py

Co-authored-by: John Bodley <john.bodley@airbnb.com>
This commit is contained in:
John Bodley
2022-05-12 21:54:23 -07:00
committed by GitHub
parent 449d08b25e
commit 89a844a40f
3 changed files with 132 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/integration_tests/reports/commands_tests.py
View File

@@ -122,6 +122,11 @@ def assert_log(state: str, error_message: Optional[str] = None):
assert state in log_states
assert error_message in [log.error_message for log in logs]
for log in logs:
if log.state == ReportState.WORKING:
assert log.value is None
assert log.value_row_json is None
def create_report_notification(
email_target: Optional[str] = None,
@@ -370,11 +375,15 @@ def create_report_slack_chart_working():
)
report_schedule.last_state = ReportState.WORKING
report_schedule.last_eval_dttm = datetime(2020, 1, 1, 0, 0)
report_schedule.last_value = None
report_schedule.last_value_row_json = None
db.session.commit()
log = ReportExecutionLog(
scheduled_dttm=report_schedule.last_eval_dttm,
start_dttm=report_schedule.last_eval_dttm,
end_dttm=report_schedule.last_eval_dttm,
value=report_schedule.last_value,
value_row_json=report_schedule.last_value_row_json,
state=ReportState.WORKING,
report_schedule=report_schedule,
uuid=uuid4(),