mirror of
https://github.com/apache/superset.git
synced 2026-04-22 09:35:23 +00:00
feat(SqlLab): Change Save Dataset Button to Split Save Query Button IV (#20852)
* Moving entire split save btn PR * Addressed review comments * Remove arbitrary div from ErrorBoundary in Chart * Added accidentally removed comment * Fix act errors in SaveQuery tests * Fix SaveDatasetActionButton test * SaveDatasetModal test almost working * SaveDatasetModal tests all passing * Clean SaveDatasetModal test * Fix create chart button and SaveDatasetModal text in SQL Lab * Fix untitled dataset name on SaveDatasetModal in explore * Fix styling on split save button
This commit is contained in:
committed by
GitHub
parent
3a11856ecb
commit
8a04536f9d
@@ -188,7 +188,7 @@ export default class ResultSet extends React.PureComponent<
|
||||
popSelectStar(tempSchema: string | null, tempTable: string) {
|
||||
const qe = {
|
||||
id: shortid.generate(),
|
||||
title: tempTable,
|
||||
name: tempTable,
|
||||
autorun: false,
|
||||
dbId: this.props.query.dbId,
|
||||
sql: `SELECT * FROM ${tempSchema ? `${tempSchema}.` : ''}${tempTable}`,
|
||||
@@ -281,11 +281,8 @@ export default class ResultSet extends React.PureComponent<
|
||||
this.props.database?.allows_virtual_table_explore && (
|
||||
<ExploreResultsButton
|
||||
database={this.props.database}
|
||||
onClick={() => this.setState({ showSaveDatasetModal: true })}
|
||||
onClick={this.createExploreResultsOnClick}
|
||||
/>
|
||||
// In order to use the new workflow for a query powered chart, replace the
|
||||
// above function with:
|
||||
// onClick={this.createExploreResultsOnClick}
|
||||
)}
|
||||
{this.props.csv && (
|
||||
<Button buttonSize="small" href={`/superset/csv/${query.id}`}>
|
||||
|
||||
Reference in New Issue
Block a user