QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-24 02:25:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(SqlLab): Change Save Dataset Button to Split Save Query Button IV (#20852)

Browse Source 
* Moving entire split save btn PR

* Addressed review comments

* Remove arbitrary div from ErrorBoundary in Chart

* Added accidentally removed comment

* Fix act errors in SaveQuery tests

* Fix SaveDatasetActionButton test

* SaveDatasetModal test almost working

* SaveDatasetModal tests all passing

* Clean SaveDatasetModal test

* Fix create chart button and SaveDatasetModal text in SQL Lab

* Fix untitled dataset name on SaveDatasetModal in explore

* Fix styling on split save button
This commit is contained in:
Lyndsi Kay Williams
2022-08-01 14:36:34 -05:00
committed by GitHub
parent 3a11856ecb
commit 8a04536f9d
25 changed files with 515 additions and 196 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
superset-frontend/src/SqlLab/components/RunQueryActionButton/index.tsx
View File

@@ -20,13 +20,11 @@ import React, { useMemo } from 'react';
import { t, styled, useTheme } from '@superset-ui/core';
import { Menu } from 'src/components/Menu';
import Button, { ButtonProps } from 'src/components/Button';
import Button from 'src/components/Button';
import Icons from 'src/components/Icons';
import {
DropdownButton,
DropdownButtonProps,
} from 'src/components/DropdownButton';
import { DropdownButton } from 'src/components/DropdownButton';
import { detectOS } from 'src/utils/common';
import { QueryButtonProps } from 'src/SqlLab/types';
interface Props {
allowAsync: boolean;
@@ -38,8 +36,6 @@ interface Props {
overlayCreateAsMenu: typeof Menu | null;
}
type QueryButtonProps = DropdownButtonProps | ButtonProps;
const buildText = (
shouldShowStopButton: boolean,
selectedText: string | undefined,
@@ -80,7 +76,7 @@ const StyledButton = styled.span`
}
span[name='caret-down'] {
display: flex;
margin-right: ${({ theme }) => theme.gridUnit * -2}px;
margin-left: ${({ theme }) => theme.gridUnit * 1}px;
}
}
`;