QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-24 02:25:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(SqlLab): Change Save Dataset Button to Split Save Query Button IV (#20852)

Browse Source 
* Moving entire split save btn PR

* Addressed review comments

* Remove arbitrary div from ErrorBoundary in Chart

* Added accidentally removed comment

* Fix act errors in SaveQuery tests

* Fix SaveDatasetActionButton test

* SaveDatasetModal test almost working

* SaveDatasetModal tests all passing

* Clean SaveDatasetModal test

* Fix create chart button and SaveDatasetModal text in SQL Lab

* Fix untitled dataset name on SaveDatasetModal in explore

* Fix styling on split save button
This commit is contained in:
Lyndsi Kay Williams
2022-08-01 14:36:34 -05:00
committed by GitHub
parent 3a11856ecb
commit 8a04536f9d
25 changed files with 515 additions and 196 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/src/SqlLab/components/ShareSqlLabQuery/ShareSqlLabQuery.test.jsx
View File

@@ -42,7 +42,7 @@ const standardProvider = ({ children }) => (
const defaultProps = {
queryEditor: {
dbId: 0,
title: 'query title',
name: 'query title',
schema: 'query_schema',
autorun: false,
sql: 'SELECT * FROM ...',

4
superset-frontend/src/SqlLab/components/ShareSqlLabQuery/index.tsx
View File

@@ -49,8 +49,8 @@ function ShareSqlLabQuery({
const theme = useTheme();
const getCopyUrlForKvStore = (callback: Function) => {
const { dbId, title, schema, autorun, sql } = queryEditor;
const sharedQuery = { dbId, title, schema, autorun, sql };
const { dbId, name, schema, autorun, sql } = queryEditor;
const sharedQuery = { dbId, name, schema, autorun, sql };
return storeQuery(sharedQuery)
.then(shortUrl => {